Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize handler after FastAPI startup #216

Merged
merged 1 commit into from
May 18, 2023
Merged

Initialize handler after FastAPI startup #216

merged 1 commit into from
May 18, 2023

Conversation

callumforrester
Copy link
Contributor

Fixes #215 see there for details of the problem.

In this change:

  • Make starting the handler a post-startup task in the FastAPI app
  • Remove unnecessary async definitions on REST endpoint resolvers
  • Store config in the FastAPI app state

@callumforrester callumforrester merged commit bd2f989 into main May 18, 2023
@callumforrester callumforrester deleted the fix-event-loop branch May 18, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosesyrett rosesyrett rosesyrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FastAPI overrides event loop settings
2 participants
@callumforrester @rosesyrett