Combine events #224
Merged
Combine events #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 90.37% 90.80% +0.42%
==========================================
Files 40 40
Lines 1174 1174
==========================================
+ Hits 1061 1066 +5
+ Misses 113 108 -5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
keithralphs
reviewed
May 23, 2023
src/blueapi/cli/amq.py
Outdated
| @@ -51,12 +51,13 @@ def on_progress_event_wrapper( | |||
| on_progress_event(event) | |||
|
|
|||
| self.app.subscribe( | |||
| self.app.destinations.topic("public.worker.event"), on_event_wrapper | |||
| self.app.destinations.topic("public.worker.events"), on_event_wrapper | |||
There was a problem hiding this comment.
We say: How come it's changed to events from event - the convention for topics/queues is singular (we believe)
There was a problem hiding this comment.
I wasn't aware of the convention, I'll change it back no problem
Provides a test to ensure data and worker events from seperate dedicated streams are published to the same topic in correct sequential order.
joeshannon
approved these changes
May 24, 2023
There was a problem hiding this comment.
@abbiemery are you happy with the changes Peter made, and for this to be merged now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176
I would really appreciate someone looking over the test in
test_reworkerfor the ordering ofWorkerEventsandDataEventsand the ordering of the types ofDataEvents. I got quite caught up in the type system here. It appears to be beyond the reach of pythons typing to accurately type this, as backed up by @WareJosephB , however I could be wrong. I tried to explain the issue in a docstring of the offending function but again, could easily have tripped up my explanation here.