Detach WatchableStatus from Status and Remove LogLevel Literal #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 89.07% 89.20% +0.12%
==========================================
Files 40 40
Lines 1126 1121 -5
==========================================
- Hits 1003 1000 -3
+ Misses 123 121 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
callumforrester
changed the title
callumforrester
requested review from
rosesyrett and
DiamondJoseph
and removed request for
rosesyrett
|
For reference pydantic/pydantic#5821 |
DiamondJoseph
approved these changes
May 23, 2023
|
Do we want an issue to revert this once the above is fixed? |
|
In favour of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending bluesky/bluesky#1585
Required because of an issue with the backwards-compatible way in which Bluesky imports protocols.
LogLevelliteral was removed and replaced with a string because pydantic has issues withLiteralbecause it is actually a function, not a class.