Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation #254

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Refactor validation #254

merged 6 commits into from
Jun 1, 2023

Conversation

callumforrester
Copy link
Contributor

This is a refactor with no changes in behaviour. It was motivated by the fact that RunEngineWorker accessed the private function _lookup_params in task.py.

  • Deprecate RunPlan and move its functionality into Task
  • Add method to Task that can optionally be called to cache the parameters, call it when run if not
  • Remove instance check on task in worker as it is no longer needed

@callumforrester
Copy link
Contributor Author

This PR includes some WIP changes to fix concurrency issues in the worker, will extract those to a separate PR when complete

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #254 (824d70d) into main (d0ffaaf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   89.82%   89.83%           
=======================================
  Files          41       41           
  Lines        1356     1357    +1     
=======================================
+ Hits         1218     1219    +1     
  Misses        138      138           
Impacted Files Coverage Δ
src/blueapi/worker/reworker.py 94.69% <100.00%> (-0.03%) ⬇️
src/blueapi/worker/task.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@callumforrester
Copy link
Contributor Author

See #255 for fixing the test issues

@callumforrester callumforrester marked this pull request as ready for review June 1, 2023 06:47
@callumforrester callumforrester merged commit c230f91 into main Jun 1, 2023
@callumforrester callumforrester deleted the refactor-validation branch June 1, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants