Fix shutdown #335
Merged
Fix shutdown #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main DiamondLightSource/blueapi#335 +/- ##
==========================================
- Coverage 86.61% 86.52% -0.09%
==========================================
Files 41 41
Lines 1554 1559 +5
==========================================
+ Hits 1346 1349 +3
- Misses 208 210 +2 ☔ View full report in Codecov by Sentry. |
abbiemery
force-pushed
the
fix-shutdown
branch
from
fc593cf to
46b2e97
Compare
|
I've added in a small check using the is_connected method. However, I am going to change up the stomp connection part slightly in another PR so it doesn't crash if you try start BlueApi without an activemq instance running. The tests will be changed/added too acordingly there. |
callumforrester
approved these changes
Nov 24, 2023
Co-authored-by: Callum Forrester <callum.forrester@diamond.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #220 . This change is to enable blueapi to be shutdown with crtl+c when the activemq drops and it can no longer connect to it.