Auto restart deployment on config change #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 41 41
Lines 1708 1708
=======================================
Hits 1540 1540
Misses 168 168 ☔ View full report in Codecov by Sentry. |
DiamondJoseph
approved these changes
May 2, 2024
This will cause the deployment to be restarted if the config is changed, e.g. the set of plans or device modules are updated, when running helm upgrade.
joeshannon
force-pushed
the
deployment-reload-on-config-change
branch
from
b296060 to
7bf3c88
Compare
joeshannon
changed the title
DiamondJoseph
approved these changes
May 2, 2024
There was a problem hiding this comment.
Performs how I'd expect it to (helm upgrade with changes to the configmap.yaml deploys the updated ConfigMap, causes the Deployment to become outdated and be re-deployed). Does require that changes to the ConfigMap are done through Helm upgrade, but that's something we should enforce anyway.
We don't seem to have a github issue for this
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
Add new restartOnConfigChange property. This will cause the deployment to be restarted if the config is changed, e.g. the set of plans or device modules are updated, when running helm upgrade. Use a variation of approach at: https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments Fixes 451.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new restartOnConfigChange property.
This will cause the deployment to be restarted if the config is changed,
e.g. the set of plans or device modules are updated, when running
helm upgrade.
Use a variation of approach at:
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments
Fixes 451.