Set umask in container #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 40 40
Lines 1667 1667
=======================================
Hits 1518 1518
Misses 149 149 ☔ View full report in Codecov by Sentry. |
joeshannon
force-pushed
the
478-set-umask-in-container
branch
2 times, most recently
from
e64c70f to
77c2373
Compare
callumforrester
approved these changes
May 23, 2024
|
Would it help to additionally add a |
|
Unsure, should be a separate PR if so |
Performing an editable install on a shared filesystem scratch area causes cache/version files to be written in the source repository. With the container's default umask of 0022 the files are not group writable which can lead to frustration when attempting to clean up the scratch area. Use the DLS "standard" of 0002. Additionally modify the looping to only pickup directories within the scratch area. Fixes #478.
callumforrester
force-pushed
the
478-set-umask-in-container
branch
from
77c2373 to
503583f
Compare
DiamondJoseph
approved these changes
May 24, 2024
|
That's a question for @coretl and @GDYendell |
|
I'll make an issue and discussion can take place there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing an editable install on a shared filesystem scratch area causes cache/version files to be written in the source repository.
With the container's default umask of 0022 the files are not group writable which can lead to frustration when attempting to clean up the scratch area.
Use the DLS "standard" of 0002.
Additionally modify the looping to only pickup directories within the scratch area.
Fixes #478.