Fix reloading the environment if there is an error #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeshannon
commented
Jun 19, 2024
There was a problem hiding this comment.
I have only added the error property to the subprocess handler (and not the ABC). This has required changes to some of the typing in main.py.
I'm a bit unsure but I thought it might save some work and if the handler is to be removed soon anyway then it could make sense.
What do you think @callumforrester @DiamondJoseph .
Note for me: the schema needs to be regenerated too.
Looking at the test failures now it seems the handler implementation is variable, perhaps I should just add to the ABC. |
joeshannon
force-pushed
the
512-reloading-env-after-error
branch
4 times, most recently
from
aa88466 to
3267dc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 91.06% 91.10% +0.04%
==========================================
Files 40 40
Lines 1779 1787 +8
==========================================
+ Hits 1620 1628 +8
Misses 159 159 ☔ View full report in Codecov by Sentry. |
joeshannon
added a commit
that referenced
this pull request
Jun 25, 2024
It is the worker state rather than the overall state of blueapi. The "state" name may be used to replace the current "initialized" in order to provide more context about the "environment" Prerequisite to #514.
joeshannon
added a commit
that referenced
this pull request
Jun 25, 2024
It is the worker state rather than the overall state of blueapi. The "state" name may be used to replace the current "initialized" in order to provide more context about the "environment". Prerequisite to #514.
joeshannon
added a commit
that referenced
this pull request
Jun 25, 2024
It is the worker state rather than the overall state of blueapi. The "state" name may be used to replace the current "initialized" in order to provide more context about the "environment". Prerequisite to #514.
joeshannon
added a commit
that referenced
this pull request
Jun 25, 2024
It is the worker state rather than the overall state of blueapi. The "state" name may be used to replace the current "initialized" in order to provide more context about the "environment". Prerequisite to #514.
joeshannon
force-pushed
the
512-reloading-env-after-error
branch
9 times, most recently
from
44bbb3f to
eb3055a
Compare
callumforrester
requested changes
Jun 26, 2024
This adds a new error_message field to the environment. Its presence is now checked against when attempting to delete the environment as if there is an error the handler is never set to initialized, so previously could not be reloaded. Fixes #512.
joeshannon
force-pushed
the
512-reloading-env-after-error
branch
from
eb3055a to
416ffc5
Compare
callumforrester
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new error field to the environment. This is now checked against when attempting to delete the environment as if there is an error the handler is never set to initialized.
Note that the property has only been added to SubprocessHandler as the BlueskyHandler ABC is likely to be removed.
Fixes #512.