Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to blueapi messaging package #589

Merged
merged 26 commits into from
Sep 5, 2024

Conversation

callumforrester
Copy link
Contributor

Replace references to blueapi messaging package with references to the bluesky stomp library

Fixes #588

@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch 2 times, most recently from 485c4b6 to 1115b91 Compare August 22, 2024 11:50
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (caf7e46) to head (7437ea5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   92.99%   92.52%   -0.47%     
==========================================
  Files          40       35       -5     
  Lines        1826     1633     -193     
==========================================
- Hits         1698     1511     -187     
+ Misses        128      122       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch 3 times, most recently from e074005 to c2a4483 Compare August 23, 2024 13:13
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from c2a4483 to bce8081 Compare August 23, 2024 13:24
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from dbdf9f4 to 53ea6ff Compare August 23, 2024 13:36
dev-requirements.txt Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh marked this pull request as ready for review August 27, 2024 13:49
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from 4e85983 to 3f2b147 Compare August 28, 2024 09:03
Copy link
Contributor

@stan-dot stan-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small readability and naming suggestions

pyproject.toml Outdated Show resolved Hide resolved
src/blueapi/cli/cli.py Show resolved Hide resolved
src/blueapi/client/event_bus.py Outdated Show resolved Hide resolved
src/blueapi/service/interface.py Show resolved Hide resolved
tests/core/fake_device_module.py Outdated Show resolved Hide resolved
tests/service/test_interface.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/blueapi/client/event_bus.py Outdated Show resolved Hide resolved
src/blueapi/service/interface.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from 3f2b147 to 258c149 Compare August 28, 2024 09:33
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from fe75ae6 to 594c1dc Compare August 28, 2024 15:33
@ZohebShaikh ZohebShaikh force-pushed the 588_remove_messaging branch from bf187f0 to bdaf11f Compare August 29, 2024 15:32


def pytest_collection_modifyitems(config, items):
if config.getoption("--skip-stomp"):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've removed this, we no longer need any special handling for STOMP in CI, can you remove the parts of the github actions that start up activemq and rabbitmq?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 tests that are used to connect to the activemq/rabbitmq...I could delete them or skip both I don't think are suitable ..

@callumforrester
Copy link
Contributor Author

@ZohebShaikh Would you be able to write some tests that cover the affected area? See https://app.codecov.io/gh/DiamondLightSource/blueapi/pull/589?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=DiamondLightSource

@ZohebShaikh ZohebShaikh mentioned this pull request Sep 3, 2024
src/blueapi/service/interface.py Outdated Show resolved Hide resolved
docs/reference/openapi.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DiamondJoseph DiamondJoseph dismissed stan-dot’s stale review September 5, 2024 10:46

Allow merge while Stan is on leave

@ZohebShaikh ZohebShaikh merged commit 012238d into main Sep 5, 2024
24 checks passed
@ZohebShaikh ZohebShaikh deleted the 588_remove_messaging branch September 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract publishing of documents etc. to message bus into a separate library
4 participants