Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth token saving #753

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Fix auth token saving #753

merged 5 commits into from
Dec 12, 2024

Conversation

ZohebShaikh
Copy link
Contributor

resolve a bug in file saving

The environment variable XDG_CONFIG_HOME contains a directory not a file path. So adding a file name in front of directory path to get a writable location

@ZohebShaikh ZohebShaikh added the bug Something isn't working label Dec 11, 2024
@ZohebShaikh ZohebShaikh requested a review from tpoliaw December 11, 2024 15:37
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (211bb49) to head (a45e15f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   93.20%   93.19%   -0.01%     
==========================================
  Files          37       37              
  Lines        2074     2072       -2     
==========================================
- Hits         1933     1931       -2     
  Misses        141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/blueapi/service/authentication.py Outdated Show resolved Hide resolved
src/blueapi/service/authentication.py Outdated Show resolved Hide resolved
tests/unit_tests/service/test_authentication.py Outdated Show resolved Hide resolved
tests/unit_tests/service/test_authentication.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh force-pushed the fix-auth-token-saving branch from 0d481b0 to a45e15f Compare December 12, 2024 15:31
@ZohebShaikh ZohebShaikh merged commit 2d77d61 into main Dec 12, 2024
29 checks passed
@ZohebShaikh ZohebShaikh deleted the fix-auth-token-saving branch December 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants