Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth test speedup #762

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Auth test speedup #762

merged 2 commits into from
Dec 17, 2024

Conversation

ZohebShaikh
Copy link
Contributor

@ZohebShaikh ZohebShaikh commented Dec 16, 2024

closes #758
The execution time for test_poll_for_token_timeout was reduced successfully:

pytest tests/unit_tests/service/test_authentication.py::test_poll_for_token_timeout  
# Before: 2s
# After: 0.25s  

Overall Suite Performance (Main vs. Branch)

Environment Main Optimized Branch Delta
Python 3.10 13.39s (295 passed, 1 skipped) 11.36s (295 passed, 1 skipped) -2.03s (-15.2%)
Python 3.11 14.99s (295 passed, 1 skipped) 13.17s (295 passed, 1 skipped) -1.82s (-12.1%)
Python 3.12 21.16s (295 passed, 1 skipped) 18.17s (295 passed, 1 skipped) -2.99s (-14.1%)
Dev Environment 15.73s (296 passed) 13.08s (296 passed) -2.65s (-16.8%)

The results from the main branch are from this action

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (13c6a59) to head (ef2fd3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files          37       37           
  Lines        2063     2063           
=======================================
  Hits         1917     1917           
  Misses        146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ZohebShaikh ZohebShaikh merged commit 86d9470 into main Dec 17, 2024
33 checks passed
@ZohebShaikh ZohebShaikh deleted the auth-test-speedup branch December 17, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth Token Timeout Test not Mocking Time Properly
2 participants