Dev2 #1
Merged
Dev2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use VSCode default formatter for everything - This changes default format for some yaml, json and svgs - Remove some redundant skips for flake8 and isort - Use pkg-name not pkg_name for pip as that is more truthful - Upload wheel in CI before testing it - Note the docstring style in CONTRIBUTING.rst
This reverts commit e10f52b.
gilesknap
force-pushed
the
dev2
branch
9 times, most recently
from
2311ad9 to
7ba17e3
Compare
gilesknap
force-pushed
the
dev2
branch
9 times, most recently
from
6fbfa0c to
cc2dd3a
Compare
coretl
reviewed
May 11, 2022
GDYendell
reviewed
May 11, 2022
coretl
reviewed
May 11, 2022
Comment on lines
+105
to
+107
| if [ '${{ matrix.lock == true }}' ]; then lock='-r requirements_dev.txt'; fi | ||
| touch requirements_dev.txt | ||
| pip install ${lock} -e .[dev] |
There was a problem hiding this comment.
Suggested change
| if [ '${{ matrix.lock == true }}' ]; then lock='-r requirements_dev.txt'; fi | |
| touch requirements_dev.txt | |
| pip install ${lock} -e .[dev] | |
| touch requirements_dev.txt | |
| pip install -r requirements_dev.txt -e .[dev] |
There was a problem hiding this comment.
But this will always lock the developer install if there is a requirements_dev.txt. We want the test matrix to be mostly unlocked.
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switching to dls-python3-skeleton