Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for ophyd async 0.9.0a1 #952

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fixes for ophyd async 0.9.0a1 #952

merged 2 commits into from
Dec 10, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Dec 9, 2024

Fixes dodal to work with changes in ophyd_async 0.9.0a1 pre-release

Instructions to reviewer on how to test:

  1. All tests pass
  2. devices connect with dodal connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99
Rename all ophyd-async enums to be uppercase. Move some methods out o…
003a09a 
…f top-level conftest.py to fix import issues
@rtuck99
Pin dodal
4349f34 
Fix system test import
@rtuck99 rtuck99 mentioned this pull request Dec 9, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (e3cf7f8) to head (4349f34).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         134      134           
  Lines        5629     5629           
=======================================
  Hits         5470     5470           
  Misses        159      159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtuck99 rtuck99 marked this pull request as ready for review December 9, 2024 15:53
@rtuck99 rtuck99 requested a review from a team as a code owner December 9, 2024 15:53
@dan-fernandes dan-fernandes mentioned this pull request Dec 10, 2024
Merged
4 tasks
@olliesilvester olliesilvester self-assigned this Dec 10, 2024
olliesilvester
olliesilvester approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@olliesilvester olliesilvester merged commit f9b3fd0 into main Dec 10, 2024
22 checks passed
@olliesilvester olliesilvester deleted the fixes_for_ophyd_async_0.9.0a1 branch December 10, 2024 14:12
huw-dls pushed a commit that referenced this pull request Dec 18, 2024
@rtuck99 @huw-dls
Fixes for ophyd async 0.9.0a1 (#952)
44b8175 
* Rename all ophyd-async enums to be uppercase. Move some methods out of top-level conftest.py to fix import issues

* Pin dodal
Fix system test import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliesilvester olliesilvester olliesilvester approved these changes

Assignees

@olliesilvester olliesilvester

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtuck99 @olliesilvester