-
Notifications
You must be signed in to change notification settings - Fork 5
WIP: Replace RunEngine management components with blueapi #648
Conversation
], | ||
"env": { | ||
"EPICS_CA_SERVER_PORT": "5066" | ||
"EPICS_CA_SERVER_PORT": "5364", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to revert before merging
EXPERIMENT_NAMES = list(PLAN_REGISTRY.keys()) | ||
EXPERIMENT_TYPE_LIST = [p["experiment_param_type"] for p in PLAN_REGISTRY.values()] | ||
EXPERIMENT_TYPE_DICT = dict(zip(EXPERIMENT_NAMES, EXPERIMENT_TYPE_LIST)) | ||
# EXPERIMENT_TYPES = Union[GridScanParams, RotationScanParams] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly everything in this module should go in __main__
, since it's just the error type left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main
now has multiple plans listed here. We will need to run all of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added full_grid_scan
too
cd91f0d
to
815376d
Compare
From offline discussion with @DominicOram a couple of weeks ago:
|
Also discussed: equivalent of |
Yh, I'm happy for GDA to just examine the Exception |
Also to do: validate on submit: DiamondLightSource/blueapi#213, could be a separate PR |
Spun out #679 for warning refactor |
… worker and context objects
…meter rationalisation
This has become a bit unwieldy and out of date. I'm going to take what we have here (thanks @callumforrester) and split it into 3 or 4 different issues/PRs |
Fixes #31
Changes:
BlueskyRunner
class and useRunEngineWorker
from blueapiBlueskyContext
from blueapiBlueskyContext
Still to do:
To test: