Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

WIP: Replace RunEngine management components with blueapi #648

Closed
wants to merge 16 commits into from

Conversation

callumforrester
Copy link

@callumforrester callumforrester commented May 11, 2023

Fixes #31

Changes:

  • Add blueapi as a dependency
  • Remove BlueskyRunner class and use RunEngineWorker from blueapi
  • Replace experiment registry functionality with BlueskyContext from blueapi
  • Create top-level plan for fast grid scans that handles the parameter translation previously handled by the experiment registry
  • Replace composite device global variable with a device stored inside BlueskyContext

Still to do:

  • Ensure equivalent tests in blueapi as for deleted runner class
  • Any extra tests in artemis
  • Error handling/status updates

To test:

  1. A/B testing: confirm scan still runs as expected

],
"env": {
"EPICS_CA_SERVER_PORT": "5066"
"EPICS_CA_SERVER_PORT": "5364",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to revert before merging

EXPERIMENT_NAMES = list(PLAN_REGISTRY.keys())
EXPERIMENT_TYPE_LIST = [p["experiment_param_type"] for p in PLAN_REGISTRY.values()]
EXPERIMENT_TYPE_DICT = dict(zip(EXPERIMENT_NAMES, EXPERIMENT_TYPE_LIST))
# EXPERIMENT_TYPES = Union[GridScanParams, RotationScanParams]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly everything in this module should go in __main__, since it's just the error type left

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main now has multiple plans listed here. We will need to run all of them

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added full_grid_scan too

@callumforrester callumforrester force-pushed the blueapi branch 2 times, most recently from cd91f0d to 815376d Compare May 12, 2023 12:34
@callumforrester
Copy link
Author

From offline discussion with @DominicOram a couple of weeks ago:

@callumforrester
Copy link
Author

Also discussed: equivalent of skip_startup_connection in bluesky context

@DominicOram
Copy link
Collaborator

Yh, I'm happy for GDA to just examine the Exception

@callumforrester
Copy link
Author

Also to do: validate on submit: DiamondLightSource/blueapi#213, could be a separate PR

@DominicOram
Copy link
Collaborator

Spun out #679 for warning refactor

@DominicOram
Copy link
Collaborator

This has become a bit unwieldy and out of date. I'm going to take what we have here (thanks @callumforrester) and split it into 3 or 4 different issues/PRs

@DominicOram DominicOram closed this Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate bluesky service
2 participants