Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beamline fixes from testing 2024-12-04 #700

Closed
rtuck99 opened this issue Dec 6, 2024 · 0 comments · Fixed by #701
Closed

Beamline fixes from testing 2024-12-04 #700

rtuck99 opened this issue Dec 6, 2024 · 0 comments · Fixed by #701

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Dec 6, 2024

This is to address issues in #697 that were fixed on the beamline during testing:

  • Fix for Deploy script no longer gives console output when running dls_dev_env.sh #242 to make the deployment scripts output to the console when they ssh into the control server
  • Fix the deloy_hyperion_to_k8s.sh script to refer to the correct folder locations and app version strings which changed due to renames elsewhere
  • Discard zocalo results with total_count below a threshold value so that background noise is ignored on non-diffracting samples.
  • Apply chi change when the specified chi is 0

Also fixes the following:

  • Always make sure setuptools_scm is installed when running deploy_hyperion_to_k8s.sh

Acceptance Criteria

  • deploy_hyperion_to_k8s.sh deploys the image without error and works for side-by-side deployment with non-containerised version
  • Non-diffracting samples always return zero hits and rotations are therefore skipped
  • Chi is always applied when specified as 0 in the request to hyperion and restores the chi before the pin-detection after a previous collection at non-zero chi.
  • deploy_mx_bluesky.py outputs to the console the install scripts being executed on the control server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant