Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

700 fix deployment issues #701

Merged
merged 11 commits into from
Dec 10, 2024
Merged

700 fix deployment issues #701

merged 11 commits into from
Dec 10, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Dec 6, 2024

Fixes #700

  • The deploy script deploy_hyperion_to_k8s.sh now deploys the image correctly (but see also Issues from mx-bluesky testing 2024-12-04 #697 where the image is broken, to be fixed in another PR)
  • deploy_mx_bluesky.py now outputs to the console when remoting to the control server
  • Zocalo results below a threshold of 3 are now ignored
  • The requested chi is now not ignored if it is 0

Also fixes the following described in #697 :

  • Always make sure setuptools_scm is installed when running deploy_hyperion_to_k8s.sh
  • Make the version check during k8s deployment more prominent and fix the pathname munging so that it compares correctly
  • Fix where the an image was built with Dockerfile.release but an image built with Dockerfile was the one actually pushed

@rtuck99 rtuck99 marked this pull request as ready for review December 6, 2024 15:37
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (1f3cb61) to head (51bd677).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
+ Coverage   86.85%   86.88%   +0.03%     
==========================================
  Files         102      102              
  Lines        6890     6899       +9     
==========================================
+ Hits         5984     5994      +10     
+ Misses        906      905       -1     
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.88% <100.00%> (+0.03%) ⬆️
other 94.15% <ø> (ø)

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please rebase before merging

@rtuck99 rtuck99 force-pushed the 700_fix_deployment_issues branch from fa03896 to 51bd677 Compare December 10, 2024 16:16
@rtuck99 rtuck99 merged commit a696064 into main Dec 10, 2024
22 checks passed
@rtuck99 rtuck99 deleted the 700_fix_deployment_issues branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beamline fixes from testing 2024-12-04
2 participants