-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
700 fix deployment issues #701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 86.85% 86.88% +0.03%
==========================================
Files 102 102
Lines 6890 6899 +9
==========================================
+ Hits 5984 5994 +10
+ Misses 906 905 -1
|
noemifrisina
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please rebase before merging
…env script instead of piping
Apply minimum count threshold of 3 to returned hits
Fix the path-name munging for the version check Add a dry run option
rtuck99
force-pushed
the
700_fix_deployment_issues
branch
from
December 10, 2024 16:16
fa03896
to
51bd677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700
deploy_hyperion_to_k8s.sh
now deploys the image correctly (but see also Issues from mx-bluesky testing 2024-12-04 #697 where the image is broken, to be fixed in another PR)deploy_mx_bluesky.py
now outputs to the console when remoting to the control serverAlso fixes the following described in #697 :
Dockerfile.release
but an image built withDockerfile
was the one actually pushed