Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up centring correctly #489

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Set up centring correctly #489

merged 5 commits into from
Sep 25, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Sep 14, 2024

Fixes #472

To test:

  • Confirm new tests pass

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (e6dcc1c) to head (312f376).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   77.88%   77.90%   +0.02%     
==========================================
  Files          89       89              
  Lines        6709     6711       +2     
==========================================
+ Hits         5225     5228       +3     
+ Misses       1484     1483       -1     
Components Coverage Δ
i24 SSX 57.12% <ø> (ø)
hyperion 96.25% <100.00%> (+0.03%) ⬆️
other 94.79% <ø> (ø)

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests now pass, thanks

@DominicOram DominicOram merged commit 3c0a8c9 into main Sep 25, 2024
21 checks passed
@DominicOram DominicOram deleted the 472_set_up_centring_correctly branch September 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to specified chis and move aperture/backlight during robot load and centre
2 participants