I24 serial: Use DetectorParams in parameter model #708
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
+ Coverage 86.89% 86.93% +0.03%
==========================================
Files 102 102
Lines 6908 6925 +17
==========================================
+ Hits 6003 6020 +17
Misses 905 905
|
| @@ -34,7 +39,9 @@ def _parse_visit(cls, visit: str | Path): | |||
|
|
|||
| @property | |||
| def collection_directory(self) -> Path: | |||
| return Path(self.visit) / self.directory | |||
| directory = Path(self.visit) / self.directory | |||
There was a problem hiding this comment.
This property is accessed in 9 different places in production code, I don't think it should be creating the directory.
|
Ok, so I've had a bit of a think, and I think there are a number of problems with I'm reluctant to approve this PR because I think on balance on its own it makes things worse rather than better, in that it spreads usage of I think a better approach would be to address part of DiamondLightSource/dodal#966 relating to the beam_xy_converter, make i24 and hyperion code both better in an incremental fashion. |
This should also take care of the beamcenter calculation.
Closes #684
Closes #647
Needs Dodal#955