Deployment script deletes old deployments #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 102 102
Lines 6908 6908
=======================================
Hits 6003 6003
Misses 905 905
|
olliesilvester
requested changes
Dec 16, 2024
olliesilvester
approved these changes
Dec 16, 2024
| for deployment in sorted_deployments[MAX_DEPLOYMENTS:] | ||
| } | ||
|
|
||
| # Removes old deployments with symlinks |
There was a problem hiding this comment.
I know i just approved but I think this comment is a bit misleading actually - sounds like we're deleting the deployments with symlinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a --prune-deployments flag, keeping 4 most recent deployments, and deleting the excess if not symlinked to hyperion_stable or hyperion_latest, following #272