Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to undulator and dcm in underlator_dcm device #718

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

shihab-dls
Copy link
Collaborator

PR 957 in dodal uses Reference to reference undulator and dcm devices in undulator_dcm composite. This PR amends mx-bluesky references to undulator_dcm.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (6317c31) to head (e1f4e0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         102      102           
  Lines        6908     6908           
=======================================
  Hits         6003     6003           
  Misses        905      905           
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.88% <100.00%> (ø)
other 94.24% <ø> (ø)

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shihab-dls shihab-dls merged commit 0042db5 into main Dec 16, 2024
22 checks passed
@shihab-dls shihab-dls deleted the undulator_dcm_as_references branch December 16, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants