Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fetch location to absolute url #119

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Change fetch location to absolute url #119

merged 3 commits into from
Feb 22, 2024

Conversation

M-Chan
Copy link
Collaborator

@M-Chan M-Chan commented Feb 22, 2024

No longer copies the whole repo into a temp directory for copier to run on.
Copier will run directly using the latest tagged repo as it's source
Gives the _commit and correct _src_path which hence allows for updates to the project in the future

Fixes #118

@M-Chan M-Chan requested a review from coretl February 22, 2024 10:01
@M-Chan M-Chan self-assigned this Feb 22, 2024
Copy link
Contributor

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you work out when backstage will update the catalog info? Does it take it from the latest tag or from main?

Regardless this change makes sense

@M-Chan M-Chan merged commit 447252d into main Feb 22, 2024
12 checks passed
@M-Chan M-Chan deleted the url2 branch February 22, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no _commit variable and incorrect _src_path
2 participants