Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SLF001 for src #174

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Enable SLF001 for src #174

merged 2 commits into from
Jul 23, 2024

Conversation

callumforrester
Copy link
Contributor

Fixes #154

  • Enable SLF001, forbidding private member access in src directory.
  • Per discussion in Enable SLF001 #154, ignore private member access violations in tests directory
  • Add test proving that ruff flags the violations

@callumforrester callumforrester force-pushed the 154-enable-slf001 branch 2 times, most recently from 7da254e to 1495c23 Compare July 1, 2024 16:12
@callumforrester
Enable SLF001 for src
e5db69c 
- Enable SLF001, forbidding private member access in src directory.
- Per discussion in #154, ignore private member access violations in
  tests directory
- Add test proving that ruff flags the violations
stan-dot
stan-dot previously approved these changes Jul 2, 2024
View reviewed changes
@coretl coretl requested a review from evalott100 July 2, 2024 08:59
@coretl
Copy link
Contributor

coretl commented Jul 2, 2024

This looks fine, but I will reserved judgement until @evalott100 has applied it to ophyd-async (which should be soon)

DominicOram
DominicOram approved these changes Jul 9, 2024
View reviewed changes
Copy link

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for this to be applied to dodal and hyperion. Thank you!

abbiemery
abbiemery approved these changes Jul 23, 2024
View reviewed changes
Copy link

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be applied to ophyd-async now.

@coretl coretl merged commit 445567b into main Jul 23, 2024
12 checks passed
@coretl coretl deleted the 154-enable-slf001 branch July 23, 2024 15:50
@abbiemery abbiemery mentioned this pull request Jul 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-perl d-perl d-perl left review comments

@abbiemery abbiemery abbiemery approved these changes

@DominicOram DominicOram DominicOram approved these changes

@stan-dot stan-dot stan-dot left review comments

@GDYendell GDYendell Awaiting requested review from GDYendell

@joeshannon joeshannon Awaiting requested review from joeshannon

@coretl coretl Awaiting requested review from coretl

@evalott100 evalott100 Awaiting requested review from evalott100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable SLF001
6 participants
@callumforrester @coretl @DominicOram @stan-dot @abbiemery @d-perl