-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recommended workflow for copier updates #214
Conversation
08801b0
to
53620c1
Compare
Did just updating dependencies and fixing before doing the update make it easier in some case? I always just update and fix everything in one go. |
So my assertion is that if there is a long break between updates. Having both new ruff (or other) errors to contend with and the changes themselves was too much. I guess this came about because I was updating to latest from an early beta version of copier template. When the checks don't even run because of fundamental issues (in my case a missing _version.py) then it's difficult to know where the problem is coming from. Perhaps I'm over thinking this though. I guess fixes for both causes of error can be performed together. My particular scenario was extreme. I'm reasonably happy to close without merging. |
Co-authored-by: Gary Yendell <gary.yendell@diamond.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash and merge?
I disabled it for the repo as we sometimes adopt from a branch and squashing loses the update ability. This doesn't apply here, so will re-enable it just for this PR... |
For projects that have not been updated for a long time I found the documented workflow helped avoid confusion of changing the template and tool versions simultaneously.