Add PyPI trusted publisher as an option #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Please can you also add a "migration" for version 2.0.0 that print a message to the user to visit https://diamondlightsource.github.io/python-copier-template/2.0.0/how-to/pypi.html to find out how to setup PyPI trusted publishing. I will add to this PR to modify pypi.md so it has the right docs and change the developer portal to match.
template/{% if git_platform=="github.com" %}.github{% endif %}/workflows/ci.yml.jinja
Outdated
Show resolved
Hide resolved
coretl
force-pushed
the
for_1.1.0_release
branch
from
4df614e to
00cdda4
Compare
|
I've force pushed and added docs so when you're done with the changes I can review it again |
M-Chan
force-pushed
the
for_1.1.0_release
branch
from
5253eb3 to
827178d
Compare
M-Chan
force-pushed
the
for_1.1.0_release
branch
from
9649e1e to
80aea67
Compare
coretl
requested changes
Feb 26, 2024
template/{% if git_platform=="github.com" %}.github{% endif %}/workflows/ci.yml.jinja
Outdated
Show resolved
Hide resolved
coretl
reviewed
Feb 27, 2024
coretl
reviewed
Feb 27, 2024
coretl
previously approved these changes
Feb 27, 2024
gilesknap
previously approved these changes
Feb 28, 2024
forces use of trusted publishing
no longer need as no ${{}} to escape anymore
coretl
force-pushed
the
for_1.1.0_release
branch
from
b04dd28 to
5b245cb
Compare
coretl
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #40