Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for removing fixed-length headers from interpreted messages #80

Merged
merged 6 commits into from
Aug 16, 2022

Conversation

MattPrit
Copy link
Collaborator

@MattPrit MattPrit commented Aug 5, 2022

Fixes #78

@DominicOram
Copy link
Collaborator

I believe failing tests are due to tholo/pytest-flake8#87 and unrelated to this PR

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #80 (da5451b) into master (eac7366) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          65       67    +2     
  Lines        2085     2097   +12     
=======================================
+ Hits         2055     2067   +12     
  Misses         30       30           
Impacted Files Coverage Δ
tickit/adapters/interpreters/wrappers/__init__.py 100.00% <100.00%> (ø)
...ers/interpreters/wrappers/beheading_interpreter.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MattPrit MattPrit marked this pull request as ready for review August 8, 2022 14:17
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I'm a fan of the idea of composing interpreters. my only real questions (detailed below) are around the location in the package and use as a decorator

@MattPrit MattPrit requested a review from garryod August 11, 2022 10:15
Copy link
Member

@garryod garryod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@DominicOram
Copy link
Collaborator

Generally looks good to me (as we pair programmed some of it) but could you add some user docs to https://github.com/dls-controls/tickit/blob/master/docs/tutorials/creating-an-adapter.rst?

@DominicOram DominicOram merged commit c0e90c0 into master Aug 16, 2022
@DominicOram DominicOram deleted the 78_remove_headers_from_messages branch August 16, 2022 16:21
@DominicOram
Copy link
Collaborator

Do expedite merging I have pulled documentation into #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for headers to be stripped from TCP commands
3 participants