-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for removing fixed-length headers from interpreted messages #80
Conversation
I believe failing tests are due to tholo/pytest-flake8#87 and unrelated to this PR |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 65 67 +2
Lines 2085 2097 +12
=======================================
+ Hits 2055 2067 +12
Misses 30 30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I'm a fan of the idea of composing interpreters. my only real questions (detailed below) are around the location in the package and use as a decorator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Generally looks good to me (as we pair programmed some of it) but could you add some user docs to https://github.com/dls-controls/tickit/blob/master/docs/tutorials/creating-an-adapter.rst? |
Do expedite merging I have pulled documentation into #87 |
Fixes #78