Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources with importlib #47

Merged
merged 1 commit into from
May 9, 2024

Conversation

ahmubashshir
Copy link
Contributor

@ahmubashshir ahmubashshir commented Nov 17, 2023

pkg_resources is deprecated in favor of importlib.{resources,metadata}

Closes #46
See-also: https://setuptools.pypa.io/en/latest/pkg_resources.html
See-also: https://docs.python.org/3/library/importlib.resources.html
See-also: https://docs.python.org/3/library/importlib.metadata.html
Signed-off-by: Mubashshir ahmubashshir@gmail.com

pkg_resources is deprecated in favor of importlib.{resources,metadata}

Closes Diaoul#46
See-also: https://setuptools.pypa.io/en/latest/pkg_resources.html
See-also: https://docs.python.org/3/library/importlib.resources.html
See-also: https://docs.python.org/3/library/importlib.metadata.html
Signed-off-by: Mubashshir <ahmubashshir@gmail.com>
@nass600
Copy link

nass600 commented Nov 19, 2023

Thanks for the PR and the library 👏 . Any chance to get the PR fixed @ahmubashshir and merged @Diaoul 🙏 ?

@ahmubashshir
Copy link
Contributor Author

Any chance to get the PR fixed
Any issue that you noticed? please add info.

@ahmubashshir
Copy link
Contributor Author

The test failures are caused by setup-poetry action.

@Safihre
Copy link

Safihre commented Jan 17, 2024

@Diaoul Any chance you might look at this one? To not break under Python 3.13.

@Diaoul Diaoul merged commit 1652736 into Diaoul:main May 9, 2024
0 of 4 checks passed
@Diaoul
Copy link
Owner

Diaoul commented May 9, 2024

New version is released 🚀

@Safihre
Copy link

Safihre commented May 9, 2024

Thanks!

@ahmubashshir ahmubashshir deleted the importlib-migration branch June 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated
4 participants