Tests/formatting

[VascoSch92]

Hey,

now all the tests are parametrised.

This is quite useful because it makes easy to quickly add more tests.

In addition, pytest generates exactly one test for each test case. This way you can see exactly which test case is causing the test to fail. That is very useful in case of nasty bugs ;-)

[Diapolo10]

There are too many exceptions for me to add to SonarQube whitelist, would you mind swapping the address literals to constants, for example something like:

IPV6_ADDRESSES = [
    '2606:4700:4700::1111',
    ...
]

TEST_CASES_IPV6 = [
    IPv6(),
    IPv6(IPV6_ADDRESSES[0]),
    IPv6(IPV6_ADDRESSES[0], 80),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80'),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80', 8080),
]

That way I wouldn't need to manually approve a hundred different ones.

[Diapolo10]

Oh yeah, apparently I've forgotten to replace pylint and flake8 in this project with Ruff. I should probably get to it.

[VascoSch92]

There are too many exceptions for me to add to SonarQube whitelist, would you mind swapping the address literals to constants, for example something like:

IPV6_ADDRESSES = [
    '2606:4700:4700::1111',
    ...
]



TEST_CASES_IPV6 = [
    IPv6(),
    IPv6(IPV6_ADDRESSES[0]),
    IPv6(IPV6_ADDRESSES[0], 80),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80'),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80', 8080),
]

That way I wouldn't need to manually approve a hundred different ones.

Yes, no problem

[Diapolo10]

I did my changes and merged them to your branch to make your life a little easier.

[VascoSch92]

There are too many exceptions for me to add to SonarQube whitelist, would you mind swapping the address literals to constants, for example something like:

IPV6_ADDRESSES = [
    '2606:4700:4700::1111',
    ...
]



TEST_CASES_IPV6 = [
    IPv6(),
    IPv6(IPV6_ADDRESSES[0]),
    IPv6(IPV6_ADDRESSES[0], 80),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80'),
    IPv6(f'[{IPV6_ADDRESSES[0]}]:80', 8080),
]

That way I wouldn't need to manually approve a hundred different ones.

Yes, no problem

I tried to do as you suggested and it is not working... Can you add the exception manually? Or can I do that?

[Diapolo10]

That's good, just gotta do the same for the other two files now

[Diapolo10]

I'll take a better look after work

[Diapolo10]

It was nothing complicated, the test result simply included the quotes of the string literal. An easy fix was to make Python treat the IP address via repr instead of str in the test case.

[VascoSch92]

can we not just add the the exception? The code will be much cleaner then....

[Diapolo10]

Okay, fine, I'll spend the weekend telling Sonarcloud to ignore the false positives. You can revert the changes to the addresses.

[VascoSch92]

Okay, fine, I'll spend the weekend telling Sonarcloud to ignore the false positives. You can revert the changes to the addresses.

Actually, I saw that you did already a lot in the code. Let's change the code ;-) I will do the rest this week

sorry for the misunderstanding

[VascoSch92]

Here we are :-)

[Diapolo10]

LGTM

[Diapolo10]

Not sure why the unit tests for the pull request aren't running, looking into it.

[Diapolo10]

Ah, whatever. It already passes the tests anyway, so I'll force-merge this. Dunno why it's not running in the pull request itself.

EDIT: This is kinda off-topic, but as you might've observed I'm starting to require signed commits on the main branches of some of my projects. I'm not going to be super strict about it, I'm going to merge this anyway, but you might want to look into GPG signing Git commits automatically. You can see my commits are verified with my own GPG signature, so you know they're all made by me and not someone impersonating me.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication