Rework s6-overlay config #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Difegue
requested changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks for this; Looks like it was more of a pain than I thought it'd be 😓
Re-adding old-fashioned text file for the PIDs feels like a bit of a step back, but I might just use those in a convenience npm stop command for source users since the subprocesses get stuck every now and then. 👍
Got a few misc. comments.
Difegue
approved these changes
Aug 29, 2022
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it works with s6-overlay 3.x