Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support scroll sdk #11815

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: support scroll sdk #11815

merged 1 commit into from
Sep 26, 2024

Conversation

dudu0506
Copy link

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@dudu0506 dudu0506 marked this pull request as draft September 25, 2024 13:44
@guanbinrui guanbinrui marked this pull request as ready for review September 26, 2024 03:06
@guanbinrui guanbinrui merged commit f1dcbdf into firefly Sep 26, 2024
1 of 3 checks passed
@guanbinrui guanbinrui deleted the feat/scroll-sdk branch September 26, 2024 03:06
dudu0506 added a commit that referenced this pull request Sep 26, 2024
guanbinrui pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants