Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hide auction items #167

Closed
FrutyX opened this issue Jan 15, 2020 · 4 comments
Closed

[Feature Request] Hide auction items #167

FrutyX opened this issue Jan 15, 2020 · 4 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Jan 15, 2020

Hello there,

so,when it comes to saving our gold into amulets and rings,you are usually buying these things that got rubies value above 40 (that's why there is the "hide your gold here" text ,right) but instead of that,you should actually give us an option into auction settings,to hide all other amulets/rings under 40 rubies , it will be much clearer and you will never missclick on a wrong rubies value.

That's it,hopefully it's possible to make,I believe that it will be great for anyone who is saving their gold via auction items.

Thank you! :)
(Btw,great job on the Addon so far)

@FrutyX FrutyX changed the title Hide auction items Hide auction items [feature request] Jan 15, 2020
@GramThanos GramThanos changed the title Hide auction items [feature request] [Feature Request] Hide auction items Jan 15, 2020
@GreatApo
Copy link
Member

GreatApo commented Feb 2, 2020

I would suggest a button at the top of the auction switching it on and off so that a player can see that this feature is enabled/disabled.

@mehmetkaradeniz
Copy link
Contributor

Probably not the best way to implement this, but can be used from browser's developer console until this feature is implemented.

jQuery(".auction_bid_div:not(:has(.gca-auction-good-price))").closest("td").hide()

Also requires "Analyze items' prices" option is turned on I'm guessing.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 10, 2020

Nice to see you really did it ! It's simple yet very useful,thank you for that.

It has one flaw tho,when you refresh the auction page,it will reset,so you have to set it every time you refresh the page.

GreatApo added a commit that referenced this issue Jul 10, 2020
@GreatApo
Copy link
Member

Done

@FrutyX FrutyX closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants