Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold and XP Icon placement #257

Closed
FrutyX opened this issue Apr 9, 2021 · 6 comments
Closed

Gold and XP Icon placement #257

FrutyX opened this issue Apr 9, 2021 · 6 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Apr 9, 2021

Chrome (tested also on Firefox),
GCA v4.3.5 (with all newest current changes on Github)

It's been there for a while, I think this occured somewhen when the Gladiatus update dropped and I wasn't paying that much attention for it, because it's just a small detail.

The Gold and XP tracking icon is kinda not aligned with the same line as the chat icon is.

Výstřižek

@GramThanos
Copy link
Member

This has been patched. It is caused by the change in the date format which pushed the Logout link to the next line at the top of the page.

At some point GF will have to fix that too. I don't know if someone reported it. It doesn't happen on all servers, it depends on the language.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Apr 9, 2021

Hehe, one thing creates another and I didn't even knew about it.

https://forum.gladiatus.gameforge.com/forum/thread/8830-logout-button-too-long-in-cz-lang/?postID=182634#post182634

When it comes to GF, I doubt this will be ever fixed :D, but we'll see.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Apr 9, 2021

I see.

You would have to add an independent css for every single language out there, which is nonsense, of course.

Because right now, margin-top: 83px; would fix it, but it would fix it most likely only for my language and it would broke for others.

Well, that sucks.

@GramThanos
Copy link
Member

Actually, instead of fixing our icon, I tried to fix the Gladiatus bug. Maybe my fix does not work an all servers :/

We do push temporary Gladiatus fixes through the addon, we have done so in the past. For example we have some images caching fixes for more than a year now (they don't understand the problem to fix it).

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 16, 2021

Actually, you know what would be the best option here?

Instead of trying to fix this, just move the icon somewhere else, in another div where it would fit.

You know where it would be interesting? Where the account buffs are, div named "buffbar", that's just an suggestion.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 20, 2021

Hmmmmmmmmmmmmmm

  • Gameforge does not care
  • Can't fix it easily because line-width depends on the language

Problematic.

Alternative 1, you can think about:

Moving it to the quick menu, yes I know, it does not belong there, quick menu is to quick access, but honestly, do you think someone would care?

Here are a few examples:

test4

test3

test2

test1

Alternative 2, you can think about:

Adding an new menu item (the icon is just an optional thing that came to my mind :D, been just playin):

menu

Alternative 3, you probably thought about

This is just an reminder for a comment above, moving the icon completely somewhere else (anchoring to a different div).

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants