4.3.5 - prep overview

[FrutyX]

(Last checked: 1.1.2022)

High priority

None.

Medium priority

None.

Low priority

None.

FINISHED

• Gold statistics rework after Gladiatus updated it's gold counter (More missing translations + Gold statistics bug #248)
  Current status: TESTING FIX - NOT INCLUDED IN THIS VERSION

• Some settings are dependant on other settings (example: Avoid or point out feature dependencies #279)
  Current status: PATCHED

• Audio system rework (Feature "Sound and Notification"  #278)
  Current status: IMPLEMENTED

• Importing settings via notes does not import language + add lang locales (Synchronizing settings between browsers #268 )
  Current status: FIXED

• Auction sorting: 2 and 3 digits does not work together well ( Auction sorting not working #235)
  Current status: FIXED

• Gold&XP Icon placement (Gold and XP Icon placement #257)
  Current status: FIXED

[GramThanos]

Hey! I just wanted to let you know that I agree and that this is helpful.
I haven't replied yet because I am in the middle of moving house so I don't have too much free time these weeks.

[FrutyX]

I see, that's understandable, don't want to push you, just a reminder GCA still exists :D :).

• List updated.

[FrutyX]

@GreatApo looks like your fix bears fruit (#257) , which is nice. Don't forget to add it on the progress list since you closed it already.

[FrutyX]

Sorry Gram, I know you are moving, but 2:0 for Apo! 😛

[GramThanos]

This week I am in Spain for work. :P and there is still some packaging 📦 left to be done back in Greece.

[FrutyX]

Wish I could help with that damn import/export notes problem (language), but that script is waaaaaaay too complicated for me.

No rush tho, enjoy Spain, try some local food :).

[FrutyX]

[FrutyX]

Changed #248 from TESTING to FIXED ,-).

[FrutyX]

I don't usually don't dig into personal things, but curiosity is my weakness (will probably kill me one day)...

After seeing your LinkedIn profiles, shit, it does make sense that you don't have time for some dead browser game, lmao.

And, I have to ask, u guys are brothers? By any chance? I could not resist.

[GreatApo]

Yeah, we are twins :P

Thanos takes care of the release the last couple of years. Normally, we would have push for a release because as you said, there are too many features/fixes. However, as he mentioned he is into a transition period now and he is mostly offline :)

[FrutyX]

Twins, yeeeeey :D.

And ye, that's fine, I've just picked the wrong time to be active here, when you are using something daily, you clearly want to improve it, despite we all know in what state Gladiatus is, and it's future, it does not mean we should just give up and throw it into a trashcan.

[FrutyX]

Changed (again) #248 to PROBLEMATIC (more details in it's issue).

[FrutyX]

Issue reworked, list reworked, list updated, removed all my other talk, so it is more clear.

[FrutyX]

@GramThanos Hey man, I very appreciate the invitation and I did accept it, but I have to mention, don't have that big expectations, I'll gladly help with anything I can, but my knowledge is basic, and I have more experience with running a website, than doing mostly javascript, to shorten it, if I can do it, I'll do it, if I can't do it, I'll just sit like a duck.

Thank you.

[GramThanos]

@FrutyX no problem man, I invited you because you are already helping.

[FrutyX]

@GramThanos, @GreatApo

Don't worry about the stuff I do directly to master now, just something I am preparing, for the documentation stuff.

[FrutyX]

So, I gotta ask guys, can we add the Troubleshooting guide to the main GitHub page and to this:

I mean, I can add it, but I better ask if you agree with it, don't want to overdo my permissions.

Also I have zero feedback on the guide itself, so if you dislike something... just name it.

[GramThanos]

@FrutyX awesome. Yes, good idea, if you have time please do add it.

[FrutyX]

Talkin' about priorities Gram... there is still #279 and #235 without any progress, you got some catching up for Christmas 😛

[GramThanos]

Aaaaaaa, low priority these are ...
Learn you will...

[FrutyX]

Damn, but they are not on the list without a reason.... I gotta find a different developer 😄.

Hmmm, Apooooooooooo? 🔊

[GreatApo]

Damn, but they are not on the list without a reason.... I gotta find a different developer 😄.

Hmmm, Apooooooooooo? 🔊

Thanos spend 5 years studying computer science but failed to identify a string/number sorting bug...

[GramThanos]

The auction sort needs to be merged with the advance packages filtering code as they solve similar issues. It is not so simple.

[FrutyX]

Oh yes, this sounds like a good plan, I'm gonna make this a little sport and brother rivalry and GCA will prosper 🤣.

[GramThanos]

I am not the one using parseInt without a base...

[FrutyX]

List updated, better take a look Gram! :D

Well, a few days will be needed to test everything in one package, #248 will need more time for testing too, #279 should probably be addressed too before a release.

And there are some little things like polishing stuff, but we are getting very close to a stable release.

Edit: Good job, both of you, and thanks.

[GreatApo]

We probably need to make a release before the new year and the next one next year

[FrutyX]

@GramThanos For the custom market labels, the value label is not translated, I probably can add it to the code, but I was thinking, maybe you can get it directly from the game (UI)? Every item has a value, and I remember you did that with Threat in a different issue.

Edit: From looking at it, it might be more difficult, than I think, huh?

[GramThanos]

This is already there, but needs improvement. I fixed it but in the wrong branch, I will have to move my changes on the correct one.

[GramThanos]

Fix pushed 7b3fdc6. Check if it works now, this is server dependent.

[FrutyX]

Still the same. Maybe it would be easier to just add the locale in the end.

Edit: Ooooh wait, It changed when I moved an item there and it seems it's staying there, so like other GCA things, it had to get loaded somehow.

Now after checking the code, I see you made it that way.

[FrutyX]

"It's Christmas..."

And Apo took it personally:

@GramThanos take notes 🤣

[FrutyX]

@GreatApo

Didn't Skars had a calculator on his website?

[GreatApo]

@GreatApo

Didn't Skars had a calculator on his website?

Has he? Don't remember 😂
I am trying to calculate the gold your guild has stolen (because you want me to) by calculating all the gold spend (assuming 30% discount).

[FrutyX]

https://gladiatus.gamerz-bg.com/calculator
Scroll down, check the source code, it's right there, it was pretty reliable if I remember it correctly.

[FrutyX]

(because you want me to)

Don't act like it's for me, I am kinda surprised you focused on this feature request, originally it came from my guild mate, not from me, but I do agree it would be useful, also you have a good idea for it.

A lot has changed since I made that request, I am not in that guild anymore, what I am trying to say is, that even if you make it possible, I will not be able to test it, but I am not saying you should not make it.

[GreatApo]

(because you want me to)

Don't act like it's for me, I am kinda surprised you focused on this feature request, originally it came from my guild mate, not from me, but I do agree it would be useful, also you have a good idea for it.

A lot has changed since I made that request, I am not in that guild anymore, what I am trying to say is, that even if you make it possible, I will not be able to test it, but I am not saying you should not make it.

We can make it work for everyone except that guild... hahaha
I just had a look, I haven't script anything.

[FrutyX]

I smell the sweet taste of progress in the air! List updated.

[FrutyX]

The auction sort needs to be merged with the advance packages filtering code as they solve similar issues. It is not so simple.

I've never been actually using the packages filter, but I agree on this.

I see there are some Issues for packages filtering, and I was thinking, would the thing @GreatApo made in #225 also work with the packages filter, with some modifications of course?

[FrutyX]

@GreatApo , @GramThanos

Boys, I have been planning to create a new issue, a talk one. Sometimes I do comment and ask you things in different Issues, and this is not ideal, for example, I've been using this Issue to comment about something (and I am doing it right now too), so that's why I would like to create such Issue that will be pinned so it is visible, the idea (template for it) is here:

TALK - Only GCA related

Sometimes, you just have a simple question, or you want to suggest something, but it isn't completely up to create a whole new issue, this is the right place to talk about it.

Rules:

1. As the name suggest, only GCA related talk here, Gladiatus topic is still tolerable, nothing else other than that.
2. No vulgarity or spam, keep this Issue clean and when you forget to mention something, just edit your previous post.
3. If you found a bug or want to make a suggestion for a feature or enhancement, create a New issue.
4. If you are having problems with GCA, make sure to read our Troubleshooting guide first.
5. You are free to use emojis and upload images, all in a reasonable amount.

In case of need, more rules might get added. Comments that will not respect these rules will be deleted.

You both good with this?

[GramThanos]

I don't have a problem. Alternatively, we can create a Discord server.

[FrutyX]

I've been thinking about a Discord server, buuuuuuuuut, I am not sure it will get any popular (we get people on it), like GitHub is our main platform now, so I am not sure if we also get any people on a discord server.

But that's just my opinion, maybe I am wrong.

[GramThanos]

I expect 4 people to join.

[GreatApo]

Guys, I track the GCA post in the Gladiatus Forum from time to time. Whoever wants to reach us, they can reach us. There is no reason to create more stuff, the player base is extremely small.

[FrutyX]

@GreatApo and about the talk issue? That's the thing, I don't want to comment Issues to tell you something, when it's not related to the Issue, and as you see, for now, I use this Issue for it, but when it's done, I will close it.

[FrutyX]

2 more days for #248 testing, but there are some bugs, so I don't know if we should fix them before a release. Current feature requests you are working on needs to be finished and polished before a release, so nothing is broken.

It seems like the release is getting further and further postponed. On one hand, you should release, because it's about time, on the other, you shouldn't, because I was wrong, when I thought we'll make it bug/error free, nothing is ever bug free.

[FrutyX]

A note I would like to mention.

I don't know how much work is to release a version, I mean, how long does it take for browsers (checking process) to release it on their stores.

We could make smaller updates (hell, even hotfixes) but I guess it's too much work (changing everything on GitHub, changing it in the addon, changing it on your website) ...

[GreatApo]

A note I would like to mention.

I don't know how much work is to release a version, I mean, how long does it take for browsers (checking process) to release it on their stores.

We could make smaller updates (hell, even hotfixes) but I guess it's too much work (changing everything on GitHub, changing it in the addon, changing it on your website) ...

Thanos has set everything up so that we can easily create the addon for multiple browsers. One problem is that Chrome has updated their manifest version from 2 to 3 which we need to update. The review time depends on the store. I think chrome is quite fast/automatic and it takes a day (we will see).
Nowadays we don't have huge bugs, everything that we find just needs small fixes. We usually try to release with all the identified bugs fixed.

[FrutyX]

Did he just did it? God be with us.

Btw - Happy new year you two :)

[GramThanos]

Happy new year!