Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbench new feature possible bug #272

Closed
FrutyX opened this issue Jun 30, 2021 · 5 comments
Closed

Workbench new feature possible bug #272

FrutyX opened this issue Jun 30, 2021 · 5 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Jun 30, 2021

Chrome 91.0.4472.124
GCA v4.3.5
(Czech language)

Hello there, so I've been using v4.3.5 for a while, and I believe i have discovered an entirely new bug, even after so long.

Now, the new feature where you can get repaired items directly from the workbench without getting to the packages is throwing an error at me, but not everytime. So I went to see what is going on, when I have been repairing my own items, it was okay, but when I did this with new crafted items, the problem occured, the window was stuck at loading and GCA noted an error, the item was sent to packages instead.

So far, it looks like it is throwing this error when trying to retrieve items that are not soulbound.

error
error2

Console:

gca.locale.js?4.3.5&built=1625071673521:63 Function "success" called gca_locale.get("global", "error") which is undefined!

I don't know if it is any useful to you, it seems that's all I can get from it, but I can reproduce it anytime.
Let me know if you need anything else from me.

Edit: Tested on Edge, error too.
Edit 2: Actually, it's not that new, is it? :) Anyways, I tested it on Firefox with 4.3.4 installed, I got this error too.

@GramThanos
Copy link
Member

The error itself is just a bad translation reference. Did this button fails a lot for you are just once in a while? (if I remember correctly, it just just checks the first and the last page of your packages to find the item)

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jun 30, 2021

Every single time when I try to repair an item that is not soulbound, this error pops up.

GramThanos added a commit that referenced this issue Jul 3, 2021
…ithm

Improved regex to match items and added biggest word from the item's title as a query keyword
@GramThanos
Copy link
Member

@FrutyX thanks for the help, the problem was mostly related to non-soulbound items, as you identified.
Please let me know it any similar problem come up.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 3, 2021

Yup! Just tested it, it is fixed.

I am happy I was helpful and thank you for the fix! :)

@FrutyX
Copy link
Collaborator Author

FrutyX commented Jul 16, 2021

Terminated, so closing this.

Re-open if needed.

@FrutyX FrutyX closed this as completed Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants