change auction tabs to auto width #332
Conversation
MiguelSOliveira
force-pushed
the
add_tab_width
branch
from
3ef03f9 to
cb2f51d
Compare
MiguelSOliveira
changed the title
|
Bruh, for me, it looks terrible.
You gotta keep in mind that everyone has a little different UI because of different languages (pixels are different). And for me, original looks best. |
|
I'm sorry, how does it look terrible? I am keeping in mind different languages which is why I'm doing this? Since right now different languages have different behaviors |
|
Because it's this:
vs
Which one would you prefer? Well I prefer the original, so the first one. You are doing Gameforge's dirty work, they should fix it in the first place, but they won't, because they don't give a shit. |
|
And for the English players and those with even longer tab names? Which one do you prefer? I'm just trying to make the tabs not crop into the above content for everyone |
|
Then don't use auto, and make it with a fixed size, so mine doesn't look like small crap. |
|
Ever heard about z-index? |
|
I'm sorry, just to clarify, are you being sarcastic or are you actually wondering if I've heard of z-index? |
|
Well, yes, I am asking. This seems better, than resizing it, because you never know how it will look like in all languages. Unless you want to see the whole banner, and you really, really need those few banner pixels to be visible. |
|
Honestly I think the 2 lines bother me about as much as you with the small sizes.. I could also add padding to the sides, but I'll wait and see if anyone else has other suggestions or shares the same view as me. If not, I'll just add this commit to my fork and use the solution for myself. And yes, I have heard about z-index, just that for this case I think that one line would be better. |
|
Ever heard about white-space (nowrap)? :D |
|
How does it look with languages with a bit more text? 🙂 |
|
I think you are just declining any other solution, than yours. |
|
That's fair... I'm really not and I'm sorry it comes off that way. I'm trying to implement responsive design, that's all. |
|
If we are okay with just fixing English, the simplest solution is to increase width by 1 pixel. That would solve my problem, so I'll wait to hear from others if that's enough. If it is, I would be happy with that! |
|
Guys, there is no reason for sarcasm and offends. We are here with the same goal. width: auto; combined with an increase of the right-left padding (eg. padding: 3px 8px;) seems a good solution for double line tabs. That been said, we probably need to enable this style only when the problem exists.... |
|
Are you both happy with my last commit 60e033b ? |
|
Miguel has to test it, in my language, there is no single double-line tab. So for me, nothing changed, which is good I think. Apo has always the best solutions somehow, as always. |
|
Nvm, I wanted to create an english acc anyway, yep, it seems to be working:
|
|
Will test tomorrow guys, and will let you know. Thank you both for testing! |
|
Looks good, I'll close this issue. Thank you! |
|
Bug |
Tested on Chrome & Firefox and multiple different languages, hopefully it will not cause mess somewhere...
Before:
After: