Fix events with a text node target #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
|
Hello, It's been a month since this PR and my issue are open, how long will it take before it will be merged, is there something you are waiting on? Or there are problems with the PR? |
|
I'm just waiting on a review, as far as I know this works. If you would like to use this fix before the PR is merged you can change your dependency to: dioxus = { git = "https://github.com/ealmloff/dioxus", branch = "fix-text-node-target-events" }
dioxus-web = { git = "https://github.com/ealmloff/dioxus", branch = "fix-text-node-target-events" } |
jkelleyrtp
approved these changes
Sep 16, 2023
Just busy on the administrative side of things! Big push for PRs and patch releases today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter code assumed that the target was an element node, but some events can be triggered on text nodes. This PR checks that the target is a element node before reading attributes
Fixes #1317