Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScopeId::ROOT #1398

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Add ScopeId::ROOT #1398

merged 2 commits into from
Aug 25, 2023

Conversation

JaniM
Copy link
Contributor

@JaniM JaniM commented Aug 25, 2023

Currently ScopeId(0) is the only way to directly refer to the root scope (useful for signals). This isn't documented anywhere afaict and it's somewhat surprising as usually ids shouldn't be constructed by the user.

This PR adds a constant that provides the root ScopeId.

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more clear, thank you!

@ealmloff
Copy link
Member

ealmloff commented Aug 25, 2023

A new rust version was released, which bumps the version of clippy that CI is running. Just ignore those for this PR. I will fix it in a separate PR (fixed)

@ealmloff ealmloff merged commit 31f8bab into DioxusLabs:master Aug 25, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants