Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Log connection errors during dx serve in desktop apps #1515

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

srid
Copy link
Contributor

@srid srid commented Oct 3, 2023

While debugging the dx cli for a hot-reload issue, I thought this would be useful to have. Let me know if I'm missing something! Previously, the if let(Ok... was silently ignoring connection errors.

Diff sans whitespace for review.

Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot reloading will try to connect when you run cargo run as well as dioxus serve --platform desktop. I added a note about the CLI for users who just use cargo.

Thank you!

@ealmloff ealmloff merged commit 0d7bc86 into DioxusLabs:master Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants