Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Newtype so that Rust-url can be IntoRoutable #1579

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add Newtype so that Rust-url can be IntoRoutable #1579

merged 3 commits into from
Oct 25, 2023

Conversation

andar1an
Copy link

since url::Url is commonly used for many crates, impl IntoRoutable for a rust-url newtype can make it more ergonomic to work with some crates.

@andar1an andar1an changed the title add newtype so that rust-url can IntoRoutable Add Newtype so that Rust-url can be IntoRoutable Oct 25, 2023
ealmloff
ealmloff approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ealmloff ealmloff merged commit b25fada into DioxusLabs:master Oct 25, 2023
10 checks passed
@ealmloff ealmloff added router Related to the router implementation tweak Small changes to improve experience labels Oct 25, 2023
@jkelleyrtp jkelleyrtp added this to the 0.5.0: Signals milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
router Related to the router implementation tweak Small changes to improve experience
Projects
None yet
Milestone
0.5.0: Signals
Development

Successfully merging this pull request may close these issues.
3 participants
@andar1an @ealmloff @jkelleyrtp