Fix fullstack history #1987
Merged
Fix fullstack history #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
bug
ealmloff
changed the title
ealmloff
force-pushed
the
fix-fullstack-history
branch
2 times, most recently
from
4f3f3ad
to
97af8ac
Compare
ealmloff
force-pushed
the
fix-fullstack-history
branch
from
97af8ac
to
55f3083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fullstack renderer renders on a dedicated thread which should be fine to block in. This PR wraps rebuilding the virtual dom in a wrapper that tells tokio it is ok to block. Rebuilding the virtual dom runs user code which may use blocking tokio operations (like reading the fullstack history)