-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Static Site Generation platform; Deduplicate hot reloading code #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealmloff
added
enhancement
New feature or request
fullstack
related to the fullstack crate
labels
Apr 2, 2024
ealmloff
changed the title
Create a Static Site Generation platform
Create a Static Site Generation platform; Deduplicate hot reloading code
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
dioxus-static-site-generation
crate that handles the setup for statically generated and hydrated sites like the docsite.Why is this a separate crate?
This is a separate crate instead of a feature in fullstack or the router because static site generation needs to pull in the sitemap from the router crate and the router crate needs to pull in the router context from the fullstack crate.
Static site generation can also make sense with or without dioxus fullstack depending on if you want a pure SSG only page or a page with SSG and hydration. This PR is focused on SSG with hydration, but we could support SSG without prerendering in the future
TODO:
Closes #2006
Closes #2249
Closes #1847