-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linker-Based Asset Propogation #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve error message when asset does not exist * change fs error message for images too * manifest path hint when path is not a file * typos in error message * store IO error
…oxus-collect-assets into search-deps-approach
I made some changes, can we have Mac tested again? cd test-package
cargo build -p manganis-cli-support --example cli
../target/debug/examples/cli build Testing if the shell command executes successfully. If the example exits without error, it works. |
3 tasks
This was referenced Jul 3, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built off of the great work done in #26. Instead of searching the compiled binary for link sections, we create helper functions for CLIs to act as a linker "intercept" to grab assets directly from unlinked object files.
While being a more ideal solution, it does complicate things:
cargo
twice. First for the regular build, second for the linker intercept. This can be omitted with once-stabilized nightly features or more difficult linker-detection systems. Ifrust-lld
becomes the default everywhere, this could become much simpler.cargo
andrustc
did it's thing. To solve this, we pass the current working directory as a linker arg that is collected when the CLI is called as a linker.What Is Added:
Testing
The way a linker is called seems fairly consistent across platforms, but that doesn't mean we missed something!
Other platforms?