Grid/width depends on height tests #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The CSS Grid algorithm requires repeating the track sizing algorithm a second time to account for cases where the width of a node depends on it's height. This PR:
axismodule public so that the gentest measure_func can use it.I also tried to create a test using a flexbox column-wrap node as a child which should also exercise this code path. However the behaviour of these nodes in Chrome/Firefox is a bit odd (essentially as if they don't do the second layout pass), and I couldn't get that test to pass (and I'm not sure if I even want to as our behaviour seems better!), so I'm just leaving it out for the time being.