Fix percent sized tracks #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
grid/percent-sized-tracks
branch
from
77dd09c to
87a38ff
Compare
Weibye
approved these changes
Jan 5, 2023
alice-i-cecile
approved these changes
Jan 5, 2023
They were previously incorrectly returning the Points variant rather than the Percent variant.
…te container size
nicoburns
force-pushed
the
grid/percent-sized-tracks
branch
from
87a38ff to
74fd28d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix percentage sized tracks:
percenthelper which was incorrectly returning thePointsvariant instead of thePercentvariantContext
#306 fixed issues with grid ITEMS with percentage sizes. This PR fixes issues with grid TRACKS with percentage sizing.