Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream #1

Merged
merged 3 commits into from
Sep 11, 2020
Merged

Merge upstream #1

merged 3 commits into from
Sep 11, 2020

Commits on Sep 10, 2020

  1. Cache refactor (#1431) 

    Reason: Cache has Fetcher-like functionality to handle both requests and
imps at a time. Internally, it still uses two caches configured and searched
separately, causing some code repetition. Reusing this code to cache
other objects like accounts is not easy.

Keeping the req/imp repetition in fetcher and out of cache allows for a
reusable simpler cache, preserving existing fetcher functionality.

Changes in this set:

Cache is now a simple generic id->RawMessage store
fetcherWithCache handles the separate req and imp caches
ComposedCache handles single caches - but it does not appear to be used
Removed cache overlap tests since they do not apply now
Slightly less code
    @laurb9
    laurb9 authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    22c454c View commit details
    Browse the repository at this point in the history

  2. Pass Through First Party Context Data (#1479)

    @SyntaxNode
    SyntaxNode authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    42e6765 View commit details
    Browse the repository at this point in the history

  3. Added new size 640x360 (Id: 198) (#1490)

    @hdeodhar
    hdeodhar authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    fa23f5c View commit details
    Browse the repository at this point in the history