Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to disable absolute coords #284

Closed
ElectroBot opened this issue Apr 8, 2019 · 28 comments
Closed

Config option to disable absolute coords #284

ElectroBot opened this issue Apr 8, 2019 · 28 comments
Labels
1.14 This issue or pull request only pertains to MC 1.14 enhancement New feature or request

Comments

@ElectroBot
Copy link

For packs or players that play without co-ords (the few of us), would it be possible to add a config option to disable the absolute co-ords this mod provides in the copy-paste tool (and have server decide setting in MP).
Thanks

@MajorTuvok
Copy link
Contributor

In my opinion it is upon the player to decide how he/she handles his/her gui and it is not upon a server to dictate a way of how to do it. I'd agree on a client only setting for this, though I don't really see the use.

How did you get to wanting to do this? What is the reasoning behind attempting to force players how they should work with their gui?

@MajorTuvok MajorTuvok added the enhancement New feature or request label Apr 9, 2019
@ElectroBot
Copy link
Author

A themed server/pack where co-ords aren't meant to be accessible or only accessible after a certain stage of progression.

@MajorTuvok
Copy link
Contributor

I still don't like enforcing gui dtuff from the server though I now at least understand what you intend to do... :)
@Phylogeny @MichaelHillcox what do you make of this?

@MajorTuvok
Copy link
Contributor

@ElectroBot wouldn't it be of more use for you, if we completly prohibited access to given Regions?

@MajorTuvok
Copy link
Contributor

MajorTuvok commented Apr 9, 2019

Thinking about that, this could also used by server owners to define certain non-buildable regions or we could allow to specify players as well so that one could ban people entirely...

@ElectroBot
Copy link
Author

That could be useful so some (having a server blacklist of chunks/region files, but it doable with other mods like FTB Utilities or Griefprevention).
For the server pack that I'm making it would be best if it were not accessible at all since once a player had the copy/paste tool they could determine their location anywhere and share that knowledge with others.

@MajorTuvok
Copy link
Contributor

Ok, I agree that this might only be doable by completly preventing the absolute coord mode...
Even though I still don't like Servers being able to enforce that, I finally also see why it might be needed. Let's see what the others have to say.

@MichaelHillcox
Copy link
Collaborator

I have one question. F3? I sort of get what you're getting at but I don't quite understand the idea behind it. Do you not want players to know where they are? or do you not want players building in anothers players chunk by using the absolute mode? if thats the case then I'll put some time in an implement this as a config mode but I'd like to fully understand the idea behind it :P

@ElectroBot
Copy link
Author

F3 co-ords are disabled (in my modpack). Players are given way to access to Signposts, antique atlas and encouraged to make roads/signposts/railways to navigate the world.

@MichaelHillcox
Copy link
Collaborator

was not aware you could do that. You do also just have the option of a player using a client side mod to show the cords? if people wanna cheat then they're gunna cheat

@ElectroBot
Copy link
Author

True, but if they want to play on a specific server there are a few mods that whitelist/graylist/blacklist client mods which will prevent most cheating.

@MichaelHillcox
Copy link
Collaborator

Hacked clients? the options are endless. I get your point to though and as it's a simple edit to make so I think I'll implement it regardless

@ElectroBot
Copy link
Author

Any chance of this being added to a 1.12 release?

@MajorTuvok
Copy link
Contributor

Not sure - @MichaelHillcox I don't think you have the time to do that either?

@MichaelHillcox
Copy link
Collaborator

I can do it but personally I feel like it's easily gotten around effectively making this pointless. Your call I guess

@MichaelHillcox MichaelHillcox added the 1.14 This issue or pull request only pertains to MC 1.14 label Oct 25, 2019
@MichaelHillcox MichaelHillcox added this to the Release 3.1.0b milestone Oct 25, 2019
@MichaelHillcox
Copy link
Collaborator

Implemented in 1.14.4
Added in bb8854e
Released for version: 3.1.0

@MichaelHillcox MichaelHillcox added the pending release These changes have not yet been released in a build label Nov 2, 2019
@MajorTuvok MajorTuvok removed the pending release These changes have not yet been released in a build label Nov 3, 2019
@ElectroBot
Copy link
Author

Thank you for adding this feature albeit in the wrong version.

@MajorTuvok
Copy link
Contributor

MajorTuvok commented Nov 6, 2019

To quote @MichaelHillcox from #383:

I've been having issues with 1.12 myself. It's a pain in the a**

Therefore no one can really work on 1.12 anymore - which makes it unlikely that stuff is back ported...

@MichaelHillcox MichaelHillcox mentioned this issue Nov 6, 2019
11 tasks
MichaelHillcox pushed a commit that referenced this issue Nov 7, 2019
@MichaelHillcox
Copy link
Collaborator

@ElectroBot
Copy link
Author

Sigh. Just noticed that going into the Edit placement in the Settings menu of the Copy-Paste tool still shows the co-ords (by default start X is 0,0,0 and end X is current co-ords). I'd be awesome if you guys were able to remove this as well. Thanks.

@MichaelHillcox
Copy link
Collaborator

If the config is off. The coords button is disabled and thus not set by default. I'm confused on your issue.

@ElectroBot
Copy link
Author

ElectroBot commented Nov 8, 2019

Ok. though I screwed up, but found out how to reproduce it.

Both "Default to absolute Coord-Mode" and "Allow absolute Coord-Mode" set to false although I doubt this matters. Whatever co-ords you have, if you right click with the copy-paste tool, it copies the current co-ords into the End X values.

Minecraft: 1.12.2
Forge 14.23.5.2838
Building Gadgets: 2.7.4

@MichaelHillcox
Copy link
Collaborator

MichaelHillcox commented Nov 8, 2019

Screenshot please

@ElectroBot
Copy link
Author

image
image

@MichaelHillcox
Copy link
Collaborator

That's a whole other bug. I'll look into it

@ElectroBot
Copy link
Author

ElectroBot commented Nov 8, 2019

Seems that X, Y and Z also have their "polarity" flipped (neg instead of pos and vice versa). Same on default configs.

@MichaelHillcox
Copy link
Collaborator

I've never quite understood that menu regardless :P it always seems pointless as selecting with the tool is a lot simpler.

@ElectroBot
Copy link
Author

ElectroBot commented Nov 8, 2019

My derp on the "polarity" (its late, but it makes sense since its relative to the start).

yeah. I can see some use for it in adjusting manually (especially if you do multiple operations from far away [not sure if your tools need to be chunkloaded to work])
EDIT For me it doesn't matter if this menu is visible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.14 This issue or pull request only pertains to MC 1.14 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants