Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stairs build down depending only on look vector and height #396

Closed
MichaelHillcox opened this issue Oct 25, 2019 · 2 comments
Closed

Stairs build down depending only on look vector and height #396

MichaelHillcox opened this issue Oct 25, 2019 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@MichaelHillcox
Copy link
Collaborator

Current the stairs mode only builds downwards if you're lower than the block you're looking at. This should be modified / made better to support:

The only way to do that is to hang off the edge, facing the block you want to build off of, and that makes the stairs build up and away from you. The only way to build stairs from your Y level down is to target a block that becomes the bottom of the stairs, and I want to be able to build down into an open space.

  • Taken from a comment on curse forge.

Basically, there is no way to build down into a whole with the stairs mode as you're always higher than the targeted block. I'm not sure how we'd go about supporting this but I think we could work it out.

@MichaelHillcox MichaelHillcox added enhancement New feature or request oversight Overlooked functionality, but not necessarily a bug question Issue is a request for clarification labels Oct 25, 2019
@MajorTuvok MajorTuvok changed the title Stairs build down depending on look vector and height Stairs build down depending only on look vector and height Oct 25, 2019
@MajorTuvok
Copy link
Contributor

For a discussion:
I think that this is something that can be solved with your intenteded mode System re-write.
We already talked on Discord about having 3 Systems:

  1. Something that provides the Block Positions that should be placed (Kind of like a PlacementSequence)
  2. Something that provides the Block to build with (Kind of like the current BlockProvider)
  3. And a "Plug-And-Play" Mode that does the transformations like deciding the Build pos or which sequence to use

So one could make this decision in the Mode via a Set of "Parameters" which would influence the way they build (*1) and which would be displayed in the RadialMenu. So In this case we'd add a "Up-By-Default" Parameter and the user could toggle that in the Menu.

*1 By influencing the way they build I mean that they could have something like a transformPre and transformPost Method which would be given the starting Position or a placementTarget respectively.

@MichaelHillcox MichaelHillcox added this to the 1.16.3-3.7.2 milestone Oct 24, 2020
@MichaelHillcox MichaelHillcox removed 1.16 oversight Overlooked functionality, but not necessarily a bug question Issue is a request for clarification labels Oct 30, 2020
@MichaelHillcox
Copy link
Collaborator Author

Moved to master list #534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants