Fix incompatibility between Connectedness and BuildingGadgets #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might be a good idea to check if the `BlockState` is null prior to calling a function from it.
|
would be very cool if this got committed any time soon |
MichaelHillcox
added a commit
that referenced
this pull request
May 20, 2024
Fix incompatibility between Connectedness and BuildingGadgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be a good idea to check if the
BlockStateis null prior to calling a function from it.This should fix the issues with Asek3/Connectedness#9 and LunaPixelStudios/Prominence#43
I tested it personally on the Prominence pack v1.0.1 as that is what my friend's server currently runs. Given that it's such a minor change, it should work universally for 1.19.3. However, a 1.19.2 version may need to be made for Prominence.