fix: update onboarding in progress translation message

Discord-InterChat · May 24, 2024 · 49849c3 · 49849c3
1 parent ab6f65b
commit 49849c3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/commands/slash/Main/hub/browse.ts b/src/commands/slash/Main/hub/browse.ts
@@ -363,7 +363,7 @@ export default class Browse extends Hub {
       }
       else if (onboardingCompleted === 'in-progress') {
         await interaction.update({
-          content: t({ phrase: 'hub.onboarding.inProgress', locale }, { channel: `${channel}` }),
+          content: t({ phrase: 'network.onboarding.inProgress', locale }, { channel: `${channel}`, emoji: emojis.dnd_anim }),
           embeds: [],
           components: [],
         });

diff --git a/src/commands/slash/Main/hub/join.ts b/src/commands/slash/Main/hub/join.ts
@@ -141,7 +141,7 @@ export default class JoinSubCommand extends Hub {
       await interaction.reply({
         embeds: [
           simpleEmbed(
-            t({ phrase: 'hub.onboarding.inProgress', locale }, { channel: `${channel}` }),
+            t({ phrase: 'network.onboarding.inProgress', locale }, { channel: `${channel}`, emoji: emojis.dnd_anim }),
           ),
         ],
         ephemeral: true,

diff --git a/src/scripts/network/onboarding.ts b/src/scripts/network/onboarding.ts
@@ -19,18 +19,15 @@ const processAcceptButton = async (
 ) => {
   await interaction?.deferUpdate();
   onboardingInProgress.delete(channelId); // remove in-progress marker as onboarding has either been cancelled or completed
-  return interaction?.customId === 'onboarding_:accept' ? true : false;
+  return interaction?.customId === 'onboarding_:accept';
 };
 
 const processNextButton = async (
   interaction: ButtonInteraction,
   channelId: string,
   locale: supportedLocaleCodes = 'en',
 ) => {
-  if (interaction?.customId !== 'onboarding_:next') {
-    onboardingInProgress.delete(channelId);
-    return false;
-  }
+  if (interaction?.customId !== 'onboarding_:next') return false;
 
   const acceptButton = new ActionRowBuilder<ButtonBuilder>().addComponents(
     new ButtonBuilder()
@@ -127,5 +124,10 @@ export const showOnboarding = async (
     })
     .catch(() => null);
 
-  return response ? await processNextButton(response, channelId, locale) : false;
+  const finalResult = response ? await processNextButton(response, channelId, locale) : false;
+
+  // in case user cancels onboarding, remove in-progress marker
+  if (finalResult === false) onboardingInProgress.delete(channelId);
+
+  return finalResult;
 };