Optimize OrderedArguments
and FieldDefinitions
cops
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a very large file where this gem's cops stuck and never finish. The reasons are that
lib/rubocop/graphql/sorbet.rb
uses O(n^2) loop andlib/rubocop/cop/graphql/ordered_arguments.rb
performs a costly traversing of the descendants tree twice, where only one would suffice.After these changes, now rubocop finishes in 17 seconds for that file.