Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle fields/arguments without kwargs #19

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Gracefully handle fields/arguments without kwargs #19

merged 1 commit into from
Jul 21, 2020

Conversation

swalkinshaw
Copy link
Contributor

While the graphql gem requires certain kwargs (like required or null), this prevents errors while Rubocop is analyzing them.

@swalkinshaw
Gracefully handle fields/arguments without kwargs
f676b43 
While the graphql gem requires certain kwargs (like `required` or `null`),
this prevents errors while Rubocop is analyzing them.
DmitryTsepelev
DmitryTsepelev approved these changes Jul 21, 2020
View reviewed changes
Copy link
Owner

@DmitryTsepelev DmitryTsepelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DmitryTsepelev DmitryTsepelev merged commit 6278c8c into DmitryTsepelev:master Jul 21, 2020
@swalkinshaw swalkinshaw deleted the handle-fields-without-kwargs branch July 21, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryTsepelev DmitryTsepelev DmitryTsepelev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swalkinshaw @DmitryTsepelev